MBS-14120: Indicate the edited release on edits entered from the relationship editor #3620
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reosarevok
force-pushed
the
MBS-14120
branch
6 times, most recently
from
6a8f511 to
aa99271
Compare
reosarevok
changed the title
mwiencek
reviewed
Sep 3, 2025
reosarevok
force-pushed
the
MBS-14120
branch
2 times, most recently
from
5c59c88 to
6d926b7
Compare
mwiencek
reviewed
Oct 4, 2025
It's often quite hard to figure out the specific source for an edit entered through the relationship editor (especially when a recording is shared between multiple releases), and yet many editors (me included!) tend to forget about it and just enter notes like "See booklet on CAA" or the like. This makes it so that edits entered from the release relationship editor get a new entered_from piece of data, allowing us to always specify what release the edit was, well, entered from.
mwiencek
approved these changes
Oct 6, 2025
reosarevok
added a commit
that referenced
this pull request
Oct 7, 2025
* master: Update POT files using the production database Fetch the solr-9.7.0.tgz distribution from our FTP (#3639) Clarify that `SSSSSS_STORAGE` needs to exist first MBS-14157: Search for URLs containing string (#3632) MBS-14120: Indicate origin release on edits from relationship editor (#3620) MBS-14159: Allow classical.apple.com (#3633) Merge pull request #3631 from reosarevok/MBS-14158 MBS-13719: Add profile option for email language Add two additional MTCaptcha tests Update HACKING-IMG.md `Server::Email`: Add `get_available_locales` method `Data::Language`: Allow lookup by any type of code Update Flow to 0.285.0 Update Flow to 0.284.0 Resolve MTCaptcha DBDefs TODO Enable MTCaptcha test mode Rename mbtest hostname alias to mbtest.local Allow enabling Low Friction Invisible MTCaptcha MBS-10039: Replace reCAPTCHA with MTCaptcha Upgrade Flow to v0.283.0 https://github.com/facebook/flow/releases/tag/v0.283.0 Upgrade Flow to v0.282.0 https://github.com/facebook/flow/releases/tag/v0.282.0 Update TESTS_IMAGE_TAG for Flow v281 Upgrade Flow to v0.281.0 Remove `ft-flow/no-flow-fix-me-comments: error` Upgrade Flow to v0.280.0 Upgrade Flow to v0.279.0 Upgrade Flow to v0.278.0 Upgrade Flow to v0.277.1 Upgrade Flow to v0.276.0 Upgrade Flow to 0.275.0 (#3628) t/selenium.mjs: Filter React DevTools log spam Replace some pauses with `waitUntilElementIsVisible` Autocomplete2: Move common code into `clearInputTimeout` Autocomplete2: Set `inputTimeout.current = null` after clearing it MBS-13963 (III): Support browsing events recursively MBS-13963 (II): Allow browsing events by multiple event MBIDs MBS-13963 (I): Support browsing events by event Use `elsif` in `event_browse` MBS-14146: Make all special purpose artists non-editable (#3626) Migrate spammers list to flow match (#3625) Merge pull request #3624 from reosarevok/MBS-14145 MBS-14111: Show area anthem in overview Add explicit test for load_subset Make target_types/source_objs explicit Update `TESTS_IMAGE_TAG` for Flow `match` syntax fixes Fix script/xgettext Replace sucrase-node with custom babel-node loader Update po2json Upgrade core-js to 3.45.1 Remove deprecated/unused Babel plugins t/no_gettext_for_admin.sh: set `-o pipefail` Upgrade hermes-related packages to 0.32.0 Improve centering Merge pull request #3614 from reosarevok/MBS-14131 Simplify MediumsWithOrderInTitle regex ## no critic bin/ts Unbreak ts install MBS-14125: Handle redirected MBIDs in the autocomplete's recent items (#3607) MBS-14141: Count English names s/a "Disc One" as useless MBS-14139: Use a scalable SVG for the video icon Add Russian to UI languages in beta (#3617) MBS-14130: move ACUM album URLs to release group (#3615) Use release_event view on reports MBS-14133: Report for releases older than label start MBS-14115: Block last.fm links from release level (#3605) MBS-14124: Only try to merge each RG once (#3606) Fix copyright year Use AccountLayoutUserT in Subscribers Move AccountLayoutUserT to types/editor Always pass an artist credit with TO_JSON Less hacky LayoutComponent picking Simplify content assignation in EntityLink Up TESTS_IMAGE_TAG for Flow match structures Migrate other switch structures to use match Use new Flow match structure for exhaustive switches Update hermes-eslint to 0.29.1 Update Flow to 0.274.2 Update Flow to 0.274.1 Remove some seemingly no longer needed Flow ignores Update Flow to 0.274.0
reosarevok
added a commit
that referenced
this pull request
Oct 13, 2025
* beta: Translated using Weblate (Chinese (Simplified Han script)) Translated using Weblate (Polish) Translated using Weblate (French) Translated using Weblate (Japanese) Translated using Weblate (Russian) Update translation files Revert "MBS-13963 (II): Allow browsing events by multiple event MBIDs" (#3642) Update POT files using the production database Fetch the solr-9.7.0.tgz distribution from our FTP (#3639) Clarify that `SSSSSS_STORAGE` needs to exist first Translated using Weblate (Norwegian Bokmål) Translated using Weblate (Chinese (Simplified Han script)) Translated using Weblate (Toki Pona) Translated using Weblate (Finnish) Translated using Weblate (Chinese (Simplified Han script)) Translated using Weblate (Russian) Translated using Weblate (Chinese (Simplified Han script)) Translated using Weblate (Chinese (Simplified Han script)) Translated using Weblate (Chinese (Simplified Han script)) Translated using Weblate (Hebrew) Translated using Weblate (Lithuanian) Translated using Weblate (Hebrew) Translated using Weblate (Portuguese) Translated using Weblate (German) Translated using Weblate (Russian) Added translation using Weblate (Persian (Old)) Translated using Weblate (Chinese (Simplified Han script)) Translated using Weblate (Hebrew) Translated using Weblate (Dutch) Added translation using Weblate (Toki Pona) Added translation using Weblate (Portuguese (Brazil)) Translated using Weblate (Turkish) Translated using Weblate (Polish) Translated using Weblate (Russian) Translated using Weblate (Russian) Translated using Weblate (Japanese) Translated using Weblate (Russian) Translated using Weblate (Japanese) Translated using Weblate (Polish) Translated using Weblate (Italian) Update translation files Translated using Weblate (Italian) MBS-14157: Search for URLs containing string (#3632) MBS-14120: Indicate origin release on edits from relationship editor (#3620) MBS-14159: Allow classical.apple.com (#3633) Merge pull request #3631 from reosarevok/MBS-14158 MBS-13719: Add profile option for email language Add two additional MTCaptcha tests Update HACKING-IMG.md `Server::Email`: Add `get_available_locales` method `Data::Language`: Allow lookup by any type of code Update Flow to 0.285.0 Update Flow to 0.284.0 Resolve MTCaptcha DBDefs TODO Enable MTCaptcha test mode Rename mbtest hostname alias to mbtest.local Allow enabling Low Friction Invisible MTCaptcha MBS-10039: Replace reCAPTCHA with MTCaptcha Upgrade Flow to v0.283.0 https://github.com/facebook/flow/releases/tag/v0.283.0 Upgrade Flow to v0.282.0 https://github.com/facebook/flow/releases/tag/v0.282.0 Update TESTS_IMAGE_TAG for Flow v281 Upgrade Flow to v0.281.0 Remove `ft-flow/no-flow-fix-me-comments: error` Upgrade Flow to v0.280.0 Upgrade Flow to v0.279.0 Upgrade Flow to v0.278.0 Upgrade Flow to v0.277.1 Upgrade Flow to v0.276.0 Upgrade Flow to 0.275.0 (#3628) t/selenium.mjs: Filter React DevTools log spam Replace some pauses with `waitUntilElementIsVisible` Autocomplete2: Move common code into `clearInputTimeout` Autocomplete2: Set `inputTimeout.current = null` after clearing it MBS-13963 (III): Support browsing events recursively MBS-13963 (II): Allow browsing events by multiple event MBIDs MBS-13963 (I): Support browsing events by event Use `elsif` in `event_browse` MBS-14146: Make all special purpose artists non-editable (#3626) Migrate spammers list to flow match (#3625) Merge pull request #3624 from reosarevok/MBS-14145 MBS-14111: Show area anthem in overview Add explicit test for load_subset Make target_types/source_objs explicit Update `TESTS_IMAGE_TAG` for Flow `match` syntax fixes Fix script/xgettext Replace sucrase-node with custom babel-node loader Update po2json Upgrade core-js to 3.45.1 Remove deprecated/unused Babel plugins t/no_gettext_for_admin.sh: set `-o pipefail` Upgrade hermes-related packages to 0.32.0 Improve centering Merge pull request #3614 from reosarevok/MBS-14131 Simplify MediumsWithOrderInTitle regex ## no critic bin/ts Unbreak ts install MBS-14125: Handle redirected MBIDs in the autocomplete's recent items (#3607) MBS-14141: Count English names s/a "Disc One" as useless MBS-14139: Use a scalable SVG for the video icon Add Russian to UI languages in beta (#3617) MBS-14130: move ACUM album URLs to release group (#3615) Use release_event view on reports MBS-14133: Report for releases older than label start MBS-14115: Block last.fm links from release level (#3605) MBS-14124: Only try to merge each RG once (#3606) Fix copyright year Update POT files using the production database Translated using Weblate (Italian) Translated using Weblate (Russian) Translated using Weblate (Catalan) Translated using Weblate (Polish) Translated using Weblate (Japanese) Use AccountLayoutUserT in Subscribers Move AccountLayoutUserT to types/editor Always pass an artist credit with TO_JSON Less hacky LayoutComponent picking Simplify content assignation in EntityLink Up TESTS_IMAGE_TAG for Flow match structures Migrate other switch structures to use match Use new Flow match structure for exhaustive switches Update hermes-eslint to 0.29.1 Update Flow to 0.274.2 Update Flow to 0.274.1 Remove some seemingly no longer needed Flow ignores Update Flow to 0.274.0 MBS-14136: Fix display of event relationship editor (#3611) MBS-12524: Improve performance of cover art uploader (#3608) Remove useless if-else MBS-14135: Load ACs for collections in API Fix `area_pkey` conflict in t/sql/mbs-10188.sql Fix `area_pkey` conflict in t/sql/filtering.sql Fix `artist_pkey` conflict in t/sql/vote_and_note_selenium.sql run_selenium_tests.sh: set -o pipefail Update Yarn to 4.9.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement MBS-14120
Description
It's often quite hard to figure out the specific source for an edit entered through the relationship editor (especially when a recording is shared between multiple releases), and yet many editors (me included!) tend to forget about it and just enter notes like "See booklet on CAA" or the like.
This makes it so that edits entered from the release relationship editor get a new
entered_frompiece of data, allowing us to always specify what release the edit was, well, entered from.Testing
Manually, plus updated the release editor selenium tests.